Skip to content

perf: trim per-tick and per-click studio work - #33

Merged
Nowkoo merged 1 commit into
fix/multitrack-recording-bugsfrom
perf/studio-hot-paths
Oct 11, 2026
Merged

Nowkoo merged 1 commit into
fix/multitrack-recording-bugsfrom
perf/studio-hot-paths

Conversation

@Nowkoo

@Nowkoo Nowkoo commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Stacked on the publish-limits PR.

  • Jukebox playback reads the block type every tick, which is cheap. It reads the record once a second, because that copies the block state and item. Ejecting or breaking the jukebox still stops playback immediately; other removals are noticed within a second.
  • The jukebox click handler checks the block type before getState(), so right-clicking chests and other block entities no longer copies them.
  • ItemsAdder station lookups resolve their reflective methods once instead of on every right-click on a block and every menu refresh. Failed lookups are not cached, because ItemsAdder may enable later.
  • Saving serializes the project once for both of its copies.
  • Startup removes studio-*.tmp files left by an interrupted write.

Validation: Java 21 mvn clean verify, 298 tests, 100% instruction and branch coverage.

🤖 Generated with Claude Code

- Jukebox playback reads the cheap block type every tick and the record,
  which copies the block state and item, once a second. Ejecting or
  breaking the jukebox still stops playback immediately.
- The jukebox click handler checks the block type before getState(), so
  right-clicking chests no longer copies their inventories.
- ItemsAdder station lookups resolve their reflective methods once
  instead of on every right-click and menu refresh.
- Saving serializes the project once for both copies.
- Startup removes studio-*.tmp files left by an interrupted write.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 30ceb88d-eeb9-4576-a49f-0b0ae17ab05e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (tests excluded in mixed PRs). label Oct 11, 2026
@Nowkoo

Nowkoo commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #28.

Base automatically changed from fix/studio-publish-limits to fix/multitrack-recording-bugs October 11, 2026 19:38
@Nowkoo
Nowkoo merged commit 0f6ff6e into fix/multitrack-recording-bugs Oct 11, 2026
2 checks passed
@Nowkoo
Nowkoo deleted the perf/studio-hot-paths branch October 11, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant