Repository navigation
fix(comscore): remove defunct Bintray Maven repository - #495
Merged
Merged
Conversation
Bintray was shut down in 2021 and comscore.bintray.com now fails the SSL handshake. Recent Gradle releases (e.g. 8.14.6) disable a repository after such a failure instead of skipping it, so resolving the dynamic THEOplayer SDK and Comscore versions fails. The Comscore SDK is published to Maven Central, which is already declared. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 718cf29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android apps using the Comscore connector fail to build with recent Gradle releases (e.g. 8.14.6):
The connector still declared
https://comscore.bintray.com/Analytics. Bintray was shut down in 2021; the host now serves a*.jfrog.iocertificate, so the SSL handshake fails. Older Gradle versions skipped the failing repository; Gradle 8.14.6 (GHSA-j5m7-59rp-24f5) disables it, and because the connector uses dynamic versions ([10.0.0, 12.0.0),6.15.+) every repository is queried and resolution fails.com.comscore:android-analytics) is published to Maven Central, which is already declared, so nothing needs to replace it.@theoplayer/react-native-analytics-comscore.Found while upgrading react-native-theoplayer's e2e app to Gradle 8.14.6 (THEOplayer/react-native-theoplayer#988).
Test plan
com.theoplayer.theoplayer-sdk-android:core:[10.0.0, 12.0.0)andcom.comscore:android-analytics:6.15.+:Could not resolve ... Repository maven2 is disabled due to earlier errorcore:11.13.0-0andandroid-analytics:6.15.0pr_android.ymlbuilds the e2e appnpm test/npm run typescriptnot affected.Generated with Devin