fix(windows): reload nothing when switching back to a connection - #3269
Merged
Merged
Conversation
A connection switch takes the pane out of the window and puts it back, so SwiftUI reruns onAppear and every task. Activation reloaded the schema on every switch for SQL engines, and several views reset or reloaded state the same way. Lifetime work now belongs to the coordinator and the owners.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every click between two connections in the connections strip reloaded the one you returned to: on PostgreSQL, four catalog queries and a whole-schema column fetch. A switch takes the pane out of the window and back, so SwiftUI reruns
onAppearand every.task. Activation then reloaded the schema wheneverchangeManager.pluginDriver == nil, which is always true for SQL engines. Other views there wiped staged work or reloaded content.Change
Verified
CoordinatorActivationTestsswitches a hosted window back and forth and sees no refetch, with a control proving the same switch fetches once the provider is gone. Measured on a Debug build against PostgreSQL withlog_statement=all.Not in this PR
USE ROLE.