Conversation
Opening a table into the preview tab empties the tab's rows before the fetch, and the results pane drew that state as an empty Spacer, so the pane went blank and the grid unmounted for the whole fetch. - A table tab in Data mode keeps its grid while it loads; a pane with nothing to draw yet shows a delayed spinner. A dismissed load error no longer resolves to a blank pane. - Retargeting a tab builds a fresh table context and query content and forgets the previous table's change marks and source file. - A superseded load no longer launches phase 2 onto the retargeted tab. - Safe Mode (Full): Cancel lowers the loading flag, and an approval runs only on the tab, table and SQL it asked about. - Becoming key always ends a deferred restore load. - A file-backed query tab is never reused for a table.
…-blank-grid # Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Opening a table into the preview tab showed a blank pane until its rows arrived: no grid, no headers, only "Executing…" in the status bar. The retarget empties the tab's rows first, and since #2892 the pane drew "running, nothing loaded" as an empty
Spacer, unmounting the grid.Change
Verified
TableLoadKeepsGridUITestsopens a slow view into the preview tab and checks the grid stays during the fetch. Unit tests cover the rest.Screenshots
A slow view opened over
customers, one second into the fetch.Not in this PR
LoadingRevealnever reveals; fixing it adds a second status bar spinner.