Skip to content

fix(DocFeedbackProvider): keep the feedback button below the docs tab bar - #1342

Merged
sukvvon merged 2 commits into
mainfrom
fix/doc-feedback-button-z-index
Oct 5, 2026
Merged

sukvvon merged 2 commits into
mainfrom
fix/doc-feedback-button-z-index

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

The per-block feedback button is positioned with -translate-y-full, so it floats above its block. On a paragraph that sits just under the sticky docs tab bar, the button lands on top of the tabs.

Its portal container carried z-[100]. The tab bar is z-30, and neither has a stacking-context ancestor other than itself, so the two compete in the root context — the button wins and paints over the tabs. Lowering the container to z-20 puts it under the bar while leaving it above the rest of the docs content.

z-20 rather than z-30: equal values fall back to DOM order, and the docs content renders after the tab bar, so z-30 would keep the button on top. It matches LibraryLayout's existing tiers (tab bar z-30, xl sidebar z-20, bottom sticky bar z-10); the sidebar sits on the left and the button on the right, so sharing z-20 with it has no visual consequence.

Checks

Verified on a local dev server, with a paragraph scrolled so its top sits just under the tab bar:

  • Before: at the button's center, elementsFromPoint returns the button.
  • After: the same point returns the tab bar's nav, with the geometry unchanged (button top=82, tab bar bottom=100).
  • A paragraph further down the page still shows the button, and it remains clickable.

tsc and lint pass.

Summary by CodeRabbit

  • Style
    • Adjusted the floating feedback button’s stacking order.

@changeset-bot

changeset-bot Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 38c9947

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sukvvon sukvvon self-assigned this Oct 5, 2026
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0f7e16bc-bc67-4b9a-8a0d-9801d6760f44
📥 Commits

Reviewing files that changed from the base of the PR and between 091a454 and 38c9947.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 94c867a7-2c8e-4403-a86b-7eb08dc0acb2
📥 Commits

Reviewing files that changed from the base of the PR and between fdee6cc and 091a454.

📒 Files selected for processing (1)
  • src/components/DocFeedbackProvider.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The floating feedback button’s portal container changes its z-index utility from z-[100] to z-20.

Changes

Feedback button stacking order

Layer / File(s) Summary
Update portal container z-index
src/components/DocFeedbackProvider.tsx
BlockButton changes the portal container’s z-index utility from z-[100] to z-20.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 091a4

The feedback button is intended to sit below the tab bar, and the reported overlap check preserves its visibility and clickability. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: keeping the feedback button below the docs tab bar.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 38c9947 Oct 05 2026, 03:26 PM

@sukvvon
sukvvon requested a review from a team October 5, 2026 15:12
@sukvvon
sukvvon merged commit d119c8f into main Oct 5, 2026
8 checks passed
@sukvvon
sukvvon deleted the fix/doc-feedback-button-z-index branch October 5, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant