fix(DocFeedbackProvider): keep the feedback button below the docs tab bar - #1342
Conversation
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe floating feedback button’s portal container changes its z-index utility from ChangesFeedback button stacking order
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The feedback button is intended to sit below the tab bar, and the reported overlap check preserves its visibility and clickability. No actionable merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 38c9947 | Oct 05 2026, 03:26 PM |
Summary
The per-block feedback button is positioned with
-translate-y-full, so it floats above its block. On a paragraph that sits just under the sticky docs tab bar, the button lands on top of the tabs.Its portal container carried
z-[100]. The tab bar isz-30, and neither has a stacking-context ancestor other than itself, so the two compete in the root context — the button wins and paints over the tabs. Lowering the container toz-20puts it under the bar while leaving it above the rest of the docs content.z-20rather thanz-30: equal values fall back to DOM order, and the docs content renders after the tab bar, soz-30would keep the button on top. It matchesLibraryLayout's existing tiers (tab barz-30, xl sidebarz-20, bottom sticky barz-10); the sidebar sits on the left and the button on the right, so sharingz-20with it has no visual consequence.Checks
Verified on a local dev server, with a paragraph scrolled so its top sits just under the tab bar:
elementsFromPointreturns the button.nav, with the geometry unchanged (buttontop=82, tab barbottom=100).tscand lint pass.Summary by CodeRabbit