Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generated Python components can miss cancellation: the runtime signals the entrypoint shell, but Python remains its child and never runs its signal handler or
finallycleanup. An optional dependency-install shell adds another wrapper.Current upstream
mastercontains both non-exechandoffs. This fix addresses signal delivery; it is not an assertion that a recent upgrade introduced the issue.Change
execPython after writing the generated program, andexecthe next command after successful dependency installation. Neither shell has any subsequent work to preserve.Validation
shalready optimizes the bare final command). Green after: all 18 process cases pass.uv lock --check, touched-Python Ruff, andgit diff --checkpass.1848474.action_required, zero jobs executed). Linux CI has not yet run.Rollout boundary
No version bump, release, deployment or downstream dependency change. Versioning/publication remains with the maintainers. Consumers must adopt the released fix and regenerate their component definitions; already-generated definitions do not change automatically.