Skip to content

fix(secrets): say who can use and change workspace secrets - #2982

Merged
camielvs merged 1 commit into
masterfrom
cvs/secrets-copy
Nov 2, 2026
Merged

camielvs merged 1 commit into
masterfrom
cvs/secrets-copy

Conversation

@camielvs

@camielvs camielvs commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Fixes two inaccurate lines of workspace-secrets copy, and rewords the notice for someone outside a workspace.

  • Who can change them. The Tangent Secrets window said "Everyone in the workspace can see and change them." Only editors can change workspace secrets; readers can only see them. Both variants now say so: "Workspace members can see them, and editors can change them." for editors, and "…but only editors can change them." for readers.
  • Where they can be used. The window, the Add a workspace secret dialog and the secret picker's "Save to" hint said the secret is for "this project", but every project in the workspace can use it. The dialog and the hint now read "Projects in the ⬡ ML Research workspace can use it in any of their pipelines.", and the window says the same of its secrets.

The picker hint repeated the dialog's sentence word for word, so it changes with it.

  • Not a member. Someone outside the workspace was told "You're not in the ⬡ Test workspace." It now says "You're not a member of the ⬡ Test workspace.", in the Secrets window and in the notice the submit dialog and the secret picker show.

Related Issue and Pull requests

Follows the workspace secrets stack, #2927 → #2944.

Type of Change

  • Bug fix

Line Breakdown

Category Added Removed
Production code 8 8
Tests 11 10
Total 19 18

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Open a Tangent project whose workspace has a team you're an editor of, and open the Secrets window. The header should say projects in this workspace can use the secrets in any of their pipelines, and that editors can change them.
  2. As a reader of the team, the header should end "but only editors can change them."
  3. Click Add a secret. The dialog's subtitle should name the workspace with its icon and say its projects can use it in any of their pipelines.
  4. In the editor, open the secret picker on a team project's argument, choose Add a secret, and set "Save to" to the workspace. The hint should say the same.
  5. As someone outside the workspace's team, open the Secrets window. The notice should say you're not a member of the workspace, and so should the submit dialog in that project.

Additional Comments

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: cvs/secrets-copy/84fe897

@camielvs
camielvs marked this pull request as ready for review November 2, 2026 22:41
@camielvs
camielvs requested a review from a team as a code owner November 2, 2026 22:41
The Secrets window said everyone in the workspace can see and change its
secrets, but only editors can change them. It, the add dialog and the
secret picker's "Save to" hint also said the secret is for this project,
when every project in the workspace can use it in any of its pipelines.

Someone outside the workspace is now told they're not a member of it,
rather than not in it, in the Secrets window and in the notice the
submit dialog and the secret picker show.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@camielvs
camielvs merged commit 28a6c7f into master Nov 2, 2026
18 checks passed
@camielvs
camielvs deleted the cvs/secrets-copy branch November 2, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants