Repository navigation
fix(secrets): say who can use and change workspace secrets - #2982
Merged
Merged
Conversation
🎩 PreviewA preview build has been created at: |
camielvs
marked this pull request as ready for review
November 2, 2026 22:41
Mbeaulne
reviewed
Nov 2, 2026
Mbeaulne
reviewed
Nov 2, 2026
Mbeaulne
reviewed
Nov 2, 2026
camielvs
force-pushed
the
cvs/secrets-copy
branch
from
November 2, 2026 22:58
2b21ce7 to
f2bcbc7
Compare
Mbeaulne
approved these changes
Nov 2, 2026
camielvs
force-pushed
the
cvs/secrets-copy
branch
from
November 2, 2026 23:01
f2bcbc7 to
b77d468
Compare
The Secrets window said everyone in the workspace can see and change its secrets, but only editors can change them. It, the add dialog and the secret picker's "Save to" hint also said the secret is for this project, when every project in the workspace can use it in any of its pipelines. Someone outside the workspace is now told they're not a member of it, rather than not in it, in the Secrets window and in the notice the submit dialog and the secret picker show. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
camielvs
force-pushed
the
cvs/secrets-copy
branch
from
November 2, 2026 23:22
b77d468 to
84fe897
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two inaccurate lines of workspace-secrets copy, and rewords the notice for someone outside a workspace.
The picker hint repeated the dialog's sentence word for word, so it changes with it.
Related Issue and Pull requests
Follows the workspace secrets stack, #2927 → #2944.
Type of Change
Line Breakdown
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments
🤖 Generated with Claude Code