Skip to content

Canary PR for OR change 11657 sv-elab update - #4698

Draft
povik wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
povik:test-svelab-update
Draft

povik wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
povik:test-svelab-update

Conversation

@povik

@povik povik commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

@povik
povik requested a review from a team as a code owner October 18, 2026 16:29
@povik
povik requested review from sombraSoft and removed request for a team October 18, 2026 16:29
@povik
povik marked this pull request as draft October 18, 2026 16:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenROAD submodule commit and changes its URL to a personal fork. The reviewer correctly pointed out that submodules should point to the official organization repository rather than a personal fork to ensure security and long-term availability.

Comment thread .gitmodules
@povik

povik commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

@sombraSoft please ignore the ping. This is not meant for review

@povik

povik commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Seemingly the build job failed because of no tags in the personal fork this PR points to:

16:36:07  + git -C ./tools/OpenROAD describe --tags
16:36:07  fatal: No names found, cannot describe anything.
script returned exit code 128

I have pushed a dummy tag but don't have Jenkins rights to restart the job. @sombraSoft @maliberty please restart or advise on process to validate QoR changes from non-Siemens contributors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant