Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD submodule commit and changes its URL to a personal fork. The reviewer correctly pointed out that submodules should point to the official organization repository rather than a personal fork to ensure security and long-term availability.
Contributor
Author
|
@sombraSoft please ignore the ping. This is not meant for review |
Contributor
Author
|
Seemingly the build job failed because of no tags in the personal fork this PR points to: I have pushed a dummy tag but don't have Jenkins rights to restart the job. @sombraSoft @maliberty please restart or advise on process to validate QoR changes from non-Siemens contributors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To validate QoR on The-OpenROAD-Project/OpenROAD#11657