Skip to content

fix: handle exponential_moving_average window_size = 1 #15492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 3 commits into from
Oct 5, 2026
+7 −3
Merged

fix: handle exponential_moving_average window_size = 1 #15492

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77e43f4
fix: handle EMA window size of one
Phaneendra-25 Oct 4, 2026
c7ac912
fix: satisfy ruff check
Phaneendra-25 Oct 4, 2026
511cd56
Update exponential_moving_average.py
cclauss Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions financial/exponential_moving_average.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ def exponential_moving_average(
Yields exponential moving averages of the given stock prices.
>>> tuple(exponential_moving_average(iter([2, 5, 3, 8.2, 6, 9, 10]), 3))
(2, 3.5, 3.25, 5.725, 5.8625, 7.43125, 8.715625)
>>> tuple(exponential_moving_average(iter([10.1, 20.02, 30.003]), 1))
(10.1, 20.02, 30.003)

:param stock_prices: A stream of stock prices
:param window_size: The number of stock prices that will trigger a new calculation
Expand Down Expand Up @@ -49,10 +51,12 @@ def exponential_moving_average(
moving_average = 0.0

for i, stock_price in enumerate(stock_prices):
if i <= window_size:
if i == 0 or window_size == 1:
moving_average = stock_price
elif i <= window_size:
# Assigning simple moving average till the window_size for the first time
# is reached
moving_average = (moving_average + stock_price) * 0.5 if i else stock_price
moving_average = (moving_average + stock_price) * 0.5
else:
# Calculating exponential moving average based on current timestamp data
# point and previous exponential average value
Expand All @@ -67,7 +71,7 @@ def exponential_moving_average(

stock_prices = [2.0, 5, 3, 8.2, 6, 9, 10]
window_size = 3
result = tuple(exponential_moving_average(iter(stock_prices), window_size))
result = tuple(exponential_moving_average(stock_prices, window_size))
print(f"{stock_prices = }")
print(f"{window_size = }")
print(f"{result = }")
Loading