Repository navigation
Revert part of ffbe97c642 - #1109
Merged
Merged
Conversation
I didn't check the implementation details of "Player#setCooldown(ItemStack, ticks)" when adding magic item support instead of leaving it material support. The ItemStack method takes the item's cooldown group to apply the cooldown, it doesn't match items in any other way. It could be misleading, as I was misled, to leave Magic Item support, especially since we already have a "key" option for explicit cooldown groups. Users would probably favour that instead of configuring an item there, then having to double-check its config for its cooldown group.
TonytheMacaroni
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't check the implementation details of
Player#setCooldown(ItemStack, ticks)when adding magic item support instead of leaving it as material support.The ItemStack method takes the item's cooldown group to apply the cooldown, it doesn't match items in any other way. It could be misleading, as I was misled, to leave Magic Item support, especially since we already have a "key" option for explicit cooldown groups. Users would probably favour that instead of configuring an item there, then having to double-check its config for its cooldown group.
NOTE: Magic Item support was added in Beta 19.