Repository navigation
test(uik): fake host telemetry sources so served-model tests pass on a box running llama-server - #136
Merged
Merged
Conversation
On Linux, DesktopAdapter's heartbeat reads /proc through the default host-telemetry sources. A test machine that happens to run a llama-server published that model into every heartbeat the suite built, so 6 of 40 served-model tests failed on the M5 and passed everywhere else. DesktopAdapter now takes an injectable `hostSources` (as host-telemetry.js already does), and the served-model tests pass faked mac sources by default. Patch by @Hermes (found and verified on the M5); applied and re-verified by @claudemb with a simulated llama-server leak on macOS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Linux,
DesktopAdapter's heartbeat reads/procthrough the default host-telemetry sources. On a test machine that happens to run allama-server, that model got published into every heartbeat the suite built. Soserved-model.test.jsfailed 6 of 40 tests on the M5 and passed on every other machine. A suite that only passes on an empty machine has the same problem as a skipped test.Change
DesktopAdaptertakes an optionalhostSourcesand passes it tocollectHostTelemetry.host-telemetry.jsalready injects its sources the same way. Production behaviour is unchanged:undefinedmeans the default sources are used.served-model.test.jspasses faked mac sources by default: instateFrom()and in the one test that builds its own adapter.The patch is by @Hermes, who found the failure and verified the fix on the M5.
Verified
Hermes, on the M5 (Linux,
llama-serverrunning), against main6f1430c: unpatched 34 pass / 6 fail, patched 40 / 0.@claudemb, on the MacBook (macOS 27) at the same base. The negative control is a preload that makes the default sources report Linux and a running
llama-server -m Leaky-Model-Q4_K_M.gguf:npm testAcross the full suite under the simulated leak, the served-model tests were the only ones affected. The telemetry and state-publisher tests already inject their sources.
🤖 Generated with Claude Code