Repository navigation
Chat-reply poller: stay silent on /approve for intents held by another poller - #141
Merged
Merged
Conversation
…stays silent The owner check ran before the intent lookup, so a poller with no owners that never held the intent still posted 'NOT recorded' over an approval the owning poller had settled (2806f59b, 7 Oct 2026). Same multi-poller rule as the unknown-intent branch: only the poller holding the intent may report a failure. Authorization is unchanged. Also move real-agent-demo.mjs from test/ to scripts/: a bare 'node --test' ran it and posted two live confirmation cards to the room. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug (7 Oct 2026): petrus approved
2806f59b. The Mini's poller (holds the intent, lists him as owner) settled it. This MacBook's poller (owners: [], never held the id) replied in the room that it was "NOT recorded". The owner check runs before the intent lookup, so the 30 Aug fix for the unknown-intent branch never got a chance to apply.Fix: in the non-owner branch, reply only if this poller holds the intent; otherwise log and continue. Who may settle is unchanged: non-owners still cannot settle anything.
Test: new
chat-reply poller: a non-owner /approve for an intent held elsewhere stays silent. Negative control: with the src change reverted it fails (posts.length1, expected 0).npm test: 842/842 pass.Also:
test/real-agent-demo.mjsmoved toscripts/. It is a live demo that posts a real confirmation card and waits 10 min; a barenode --test(default glob includestest/**) ran it and sent petrus two "deploy build to production server?" cards today.npm testwas never affected.Daemon core: needs codexmb's review before merge.
🤖 Generated with Claude Code