Repository navigation
Add opt-in Fleet model-switch bridge for desktop devices - #142
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9344bc48f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return r; | ||
| } | ||
| async refresh() { | ||
| if (!this.enabled) return {}; |
There was a problem hiding this comment.
Clear chooser fields when disabling the bridge
When a daemon that previously published chooser data is restarted without INTENT_CHOOSER_URL, this returns no chooser fields while the desktop continues sending heartbeats. Because the device endpoint is explicitly a partial update (README.md:51), the prior model_catalog and brain_of values remain on the live device slot indefinitely even though switch polling is now off, leaving the UI advertising stale, unusable choices. The disabled path needs to overwrite the chooser-specific fields with empty values, at least during this transition.
Useful? React with 👍 / 👎.
Summary
Validation
Rollout
Not deployed. Requires the companion GroupMind switch route. One chooser-enabled device publisher per user/device; preserve its state file. This is no-replay recovery, not a distributed exactly-once guarantee. Petrus merges; ClaudeMB owns m5 rollout from a separate worktree without changing Hermes daemon.