Repository navigation
Ignore opaque URIs in calendar deep links - #22
Merged
Tricked-dev merged 1 commit intoOct 21, 2026
Merged
Conversation
MainActivity is exported, so an explicit intent can deliver any URI. Uri.getQueryParameter throws on opaque URIs such as solidtime:calendar, which crashed the activity. Return no calendar date for them instead.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MainActivityis exported, so any installed app can start it with an explicit intent carrying any data URI.calendarDateFromUricallsUri.getQueryParameter, which throwsUnsupportedOperationExceptionfor opaque URIs such assolidtime:calendar?date=2026-08-11. The exception crashes the app.Fix
calendarDateFromUrireturnsnullfor non-hierarchical URIs before reading any query parameters.solidtime://calendar?date=yyyy-MM-ddandsolidtime://calendar/yyyy-MM-ddstill resolve as before.Tests
CalendarDeepLinkUriTest. It checks that query and path calendar links still resolve, and that opaque URIs returnnullinstead of throwing. The opaque-URI test fails withUnsupportedOperationExceptionwithout the fix and passes with it.adb shell am start -n dev.tricked.solidverdant.dev/dev.tricked.solidverdant.MainActivity -a android.intent.action.VIEW -d 'solidtime:calendar?date=2026-08-11'crashes themasterbuild (UnsupportedOperationException: This isn't a hierarchical URIatCalendarDeepLink.kt:23). With this change the activity opens and nothing is written to the crash buffer.spotlessCheck testDebugUnitTest lintDebug assembleDebug assembleDebugAndroidTestpass locally (990 unit tests, 0 failures).CalendarDeepLinkE2eTestfails in CI beforeonCreateruns (last lifecycle transition = "PRE_ON_CREATE"). It fails the same way on unmodifiedmaster(f62e1eb) on a local emulator, so the failure was already there before this change.