Repository navigation
Conversation
Try
reviewed
Oct 8, 2026
Contributor
Author
|
Dropped the separate scaling logic in favour of #1014. This PR only adjusts its screen-fit limit to use the safe area. |
Owner
|
Testing this on PC, with exaggerated safe-rect. Here how main menu looks: My understanding that correct layout is to leave menu(and anything with |
Try
reviewed
Oct 20, 2026
|
|
||
| if(showHealthBar) | ||
| drawBar(p,barHp, 10, h()-10, hp, AlignLeft | AlignBottom); | ||
| drawBar(p,barHp, area.x+10, area.y+area.h-10, hp, AlignLeft | AlignBottom); |
Owner
There was a problem hiding this comment.
h()-10
area.y+area.h-10
10 was logically already an attempt of padding. It's probably better to have h() - max(10, margin().bottom)
Contributor
Author
|
Fixed the centering: menus stay at the screen center unless they overlap the safe area. HUD padding now uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep menus, HUD and touch controls inside the iOS safe area, and scale the default interface to fit. Keep inventory rows below the scaled header on iOS. World rendering and videos stay full-screen.