Repository navigation
Monsters with a weapon always deal full damage (#990) - #1021
Open
kroplabeskidu wants to merge 1 commit into
Open
kroplabeskidu wants to merge 1 commit into
kroplabeskidu wants to merge 1 commit into
Conversation
Vanilla skips the hitchance roll for any attacker that IsMonster(), equipped weapon doesn't matter. Skeletons were rolling against hitchance[1H]=0 and doing (dmg-1)/10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skeletons have a weapon equipped, so
talis 1H/2H, theisMonster() && tal==TALENT_UNKNOWNcheck is skipped and they roll againsthitchance[tal], which is 0 for monsters. Every hit becomes(vd-1)/10.In vanilla
oCNpc::OnDamage_Hitskips the hitchance roll completely if the attackerIsMonster(), weapon or not.IsMonster()there is not human, not orc and not dragon/fire golem/ice golem, so goblins and skeletons count.Tested with
SKELETON(str 100, ItMw_2H_Sword_M_01 = 50) vs a fresh hero (40 hp, no armor): 14 per hit before, 150 after, one hit like in vanilla.Fixes #990