Repository navigation
Translate X11 keys without modifiers - #135
Merged
Merged
Conversation
With shift held Xutf8LookupString returns upper-case keysym, which is not mapped, so key release of a letter was lost
Contributor
|
I noticed the same issue in X11 while comparing it to the Wayland input handling. This also fixes CapsLock on. |
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found it in OpenGothic: hold W, press shift, release W, then shift. character keeps running forever, same with A/D turning
ksym from XLookupKeysym(..,0) gets overwritten by Xutf8LookupString, with shift it's upper-case 'W', translateKey only maps a..z so it becomes K_NoKey and the key-up never reaches the game. now key is translated from the unmodified keysym, text is still from Xutf8LookupString