Repository navigation
fix: keep the server_url path when splitting PDFs - #355
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
No issues found across 7 files
Shadow auto-approve: would not auto-approve. This PR does not meet the repository auto-approval settings.
View guided diff | Re-trigger cubic
cragwolfe
left a comment
There was a problem hiding this comment.
Oracle Pro review of exact head f2d0372ce6c6b8f55f7950a6fb946ac084eff619.
No concrete actionable defects found. I verified the URL change against the SDK's partition URL construction and split hook: it preserves the encoded deployment prefix, uses the actual per-call request URL, and keeps routing state local to each request. The checked-in sync/async tests cover default and per-call URLs, nested and encoded paths, and split/unsplit requests. Existing memory and concurrency behavior is unchanged by this diff.
Exact-head CI: unit, integration, contract, platform integration, lint, CodeQL and security checks succeeded; Claude was skipped. No local tests were run. Oracle's completed browser verdict was SAFE TO MERGE; Pro was confirmed before submission and during processing. The CLI capture timed out, so the completed response was retained directly from the original browser conversation.
(authored by codex)
What
PDF splitting now works when
server_urlincludes a path, such as a self-hosted API behind/deployment.Why
Before sending the split page requests, the SDK makes one extra request to the API. It built that URL from the host alone, dropping any path in
server_url. It now builds that URL from the actual partition request, so a path in either the client'sserver_urlor a per-callserver_urlis kept. The page requests themselves already used the right URL.The helper that built the old URL has no other callers, so it is removed along with its test.
Validation
Offline tests cover sync and async calls, with and without a per-call
server_url, and plain, nested, and URL-encoded paths. Unit tests, pylint, and mypy pass. Adds a CHANGELOG entry and bumps the version to 0.46.3.