Repository navigation
Conversation
Shamzik
added
runtime
Shamzik
requested review from
LLirikkkk and
apolyakov
and removed request for
LLirikkkk
October 9, 2026 10:26
LLirikkkk
approved these changes
Oct 10, 2026
apolyakov
requested changes
Oct 10, 2026
| kphp::stl::vector<k2::LogTaggedEntry, kphp::memory::script_allocator> tagged_entries{}; | ||
| tagged_entries.reserve(tagged_entries_size); | ||
| size_t tagged_entries_size{}; | ||
| static constexpr size_t TAGGED_ENTRIES_BUFFER_SIZE = 8UZ; |
Contributor
There was a problem hiding this comment.
Let's reserve more space for tags. Something like 20 should be ok for now
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
log::assertionwithlog::errorhandling OOM in pool allocator.It is also rewrites
kphp::log::impl::logfunction so it does not call pool allocator recursivly