Repository navigation
update CheckCXXFeatures - #22
Merged
Merged
Conversation
evaleev
added a commit
to ValeevGroup/BTAS
that referenced
this pull request
Feb 9, 2026
evaleev
force-pushed
the
feature/check-cxx-features
branch
from
October 28, 2026 12:16
256d946 to
6d115a5
Compare
…per-project result so it can be run multiple times
evaleev
force-pushed
the
feature/check-cxx-features
branch
from
October 28, 2026 12:17
6d115a5 to
624173e
Compare
… checks whenever the C++ standard library is libc++ (not only for Clang), and derives the Clang-specific remedy only for Clang with a GNU-style driver
Contributor
|
FYI: Force-pushing + deleting this branch seems to have broken SeQuant CI (see current failure on master). I'll update SeQuant to point to |
Krzmbrzl
added a commit
to Krzmbrzl/SeQuant
that referenced
this pull request
Oct 28, 2026
We used to fetch from a separate feature branch which just got force-pushed merged (ValeevGroup/kit-cmake#22) which seems to have made the relevant commit disappear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the CMake feature checks in
modules/CheckCXXFeatures.cmaketo improve handling of compiler-specific C++ features. The most significant change is the addition of a new macro for checking support for the C++ feature P0522R0 (relaxed matching of template template arguments), which is required for certain template usages. Additionally, the pull request refactors the way linker check variables are named to avoid conflicts in multi-project builds.C++ feature checks:
vgkit_check_p0522r0to detect compiler support for P0522R0 (relaxed template template argument matching), and to set a compile flag if necessary, or fail with a clear error if unsupported.Refactoring and variable scoping:
VGKIT_LIBCXX_LINKS_${PROJECT_NAME}andVGKIT_LIBCXX_LINKS_WITH_FLAGS_${PROJECT_NAME}) to prevent variable collisions when used in multiple projects. [1] [2]