Repository navigation
Optimize verification lookups and fix HTTP registration contracts - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated verification lookups rebuild temporary columns, while HTTP registration reads only headers and leaves successful responses at the default 404. Cache lookup columns until the current list changes, preserve loose comparison and lookup precedence, and keep original row keys. Accept CivilizationBot form-encoded bodies while retaining legacy internal header strings; return explicit 200 on registration and support Discord-only SS13 deletion.
Add isolated no-write contract tests, a reproducible in-memory benchmark, and real PHP 8.2/8.4 CI tests. Align the manifest with the existing PHP 8.2 syntax requirement. Legacy configuration-dependent tests remain excluded and documented.
Validation: PHP 8.5.9, 5 tests / 32 assertions; composer validate --strict; git diff --check. At 10,000 synthetic rows, 200 lookups improved from 55.3 ms to 29.8 ms; at 50,000, 409.9 ms to 159.1 ms. Cached columns add memory; database fetch behavior is unchanged. No production I/O or bot startup.