Repository navigation
Fix server loading on PHP 8.2 and 8.3 and lint all source - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading VerifierServer\Server fails on PHP 8.2 and 8.3 because its HttpServer construction uses PHP 8.4-only unparenthesized method chaining. Parenthesize the constructor expression without changing runtime behavior or the PHP ^8.2 support declaration.
Add a reusable whole-package parser check for source, entry points, scripts and tests, and an offline regression test that loads Server, installs in-memory state and routes a synthetic React request without initializing a socket. Extend CI to PHP 8.2, 8.3, 8.4 and 8.5. This catches the server-loading gap left by endpoint-only tests.
Local PHP 8.5.9 validation: 28 PHP files parsed; isolated PHPUnit 6 tests / 37 assertions passed; composer validate --strict and git diff --check passed. No dotenv loading, production requests, socket binding, deployment or restart. The primary checkout's unrelated socket/port edits are excluded.