Skip to content

E2E: remaining click-then-assert-on-route-capture races in notification specs #1795

Open

Description

@Wikid82

What: tests/settings/notifications.spec.ts (Discord contract, ~line 1287) still reads preview and create payloads captured in page.route() handlers right after a click, which is the pattern that made four specs fail intermittently (fixed in #1790 for the save, test, delete and create paths). Other specs may share it.

Where: tests/settings/notifications.spec.ts and any spec asserting a route-captured variable immediately after a click.

Evidence: #1790 CI shard 3 failure analysis; the fixed specs now wait for the request first.

Severity: low

Suggestion: grep for route handlers assigning to outer variables followed by a bare assertion, and switch to page.waitForRequest/waitForResponse registered before the click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    • Status
      Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions