Repository navigation
fix(wbfy): respect compiler scopes for roots with src - #1503
Merged
Merged
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
…ncludes Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A workspace root with
srcis checked as an independent compiler project. Adding workspace sources to that project's tsconfig makes its compiler apply root settings to package-local aliases and browser globals, even when each workspace's own check passes.Requirements
Customer Summary
Roots with their own source code can type-check without false errors from independently compiled workspace packages. Roots without source code retain their existing fallback checks.
Technical Summary
packages/wbfy/src/generators/tsconfig.tsuses the samesrcdirectory distinction as the compiler caller when adding workspace includes and retiring workspace exclusions. Existing complete-prefix cleanup removes obsolete generated includes when a root becomes independent. Authored exclusions remain intact in that mode.The regression creates a real project tree, discovers its configuration from disk, generates tsconfigs, and runs the actual
wb typecheckCLI. It checks root/workspace compiler isolation and error propagation, then removes root sources and checks fallback coverage for a workspace that does not compile itself.Testing
bun run verifypassed in shared.bun wb test -w packages/wbfy test/unit/tsconfig.test.ts: 18 passed.bun wb test -w packages/wbfy test/unit/workspaceDiscovery.test.ts: 16 passed.GH_TOKEN=$(gh auth token) bun start <target-path>; itsbun run verifypassed.e063de4b470896db28f98c61269eade62078c0e0.Notes
The existing cognitive-complexity warning in
removeStaleManagedWorkspaceEntriesremains. Splitting its managed include/exclude retirement logic would only move complexity into an unrelated refactor; there are no code-gauge errors in shared.