Skip to content

fix(deps): bump tokio past RUSTSEC-2026-0386 (all Rust lockfiles) - #406

Merged
Nic-dorman merged 1 commit into
mainfrom
nic/v2-1734-rustsec-2026-0386-tokio
Oct 23, 2026
Merged

Nic-dorman merged 1 commit into
mainfrom
nic/v2-1734-rustsec-2026-0386-tokio

Conversation

@Nic-dorman

Copy link
Copy Markdown
Member

Fixes the osv-scanner failure on #392 and #400: RUSTSEC-2026-0386, published 2026-10-23. tokio's AsyncFd constructors violate I/O safety, which allows a use-after-free (Unix-only, informational). Patched in tokio 1.51.6 and in 1.53.3 or later. The 1.52.x line has no fix.

Lockfile-only:

  • antd/Cargo.lock: tokio 1.52.1 → 1.53.3 (2 lines)
  • antd-rust/Cargo.lock: 1.52.3 → 1.53.3 (2 lines)
  • ffi/node/Cargo.lock: 1.53.1 → 1.53.3 (2 lines)
  • ffi/rust/Cargo.lock: 1.50.0 → 1.51.6, plus tokio-macros 2.6.1 → 2.7.2, which brings in syn 3.0.9 (a build-time proc-macro)

Reachability: no ant-sdk code uses AsyncFd. The only crate known to use it is interprocess, which antd-rust pulls in only as a dev-dependency, through alloy. Risk is very low; this change clears the audit.

Verified on Windows with cargo 1.97.1:

  • cargo metadata --locked and cargo check --locked --all-targets pass in all four crates.
  • osv-scanner before and after: RUSTSEC-2026-0386 is gone from each lock, and nothing new appears.
  • The version and checksum were edited by hand, because cargo update --precise on cargo 1.97 also rewrites unrelated windows-sys/socket2 edges.

Other affected repos are tracked under V2-1733.

Closes V2-1734

🤖 Generated with Claude Code

antd 1.52.1 -> 1.53.3, antd-rust 1.52.3 -> 1.53.3, ffi/node 1.53.1 -> 1.53.3,
ffi/rust 1.50.0 -> 1.51.6 (also tokio-macros 2.6.1 -> 2.7.2, which pulls in
syn 3.0.9 as a proc-macro dependency). Lockfile-only; each lock still passes
cargo check --locked.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@MaidSafe-Hermes MaidSafe-Hermes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — reviewed head aa932ba8a42b5cf3a7564aecaae646734ae9843b. The change is limited to the four stated Cargo.lock files. All four updated crate checksums match crates.io; the tokio-macros/syn graph change is internally consistent. Rust CI, cargo-audit, and osv-scanner checks pass, including ant-ffi. The sol-1 verification concern is resolved by these checksum and CI results. 2/2 seats reviewed (sol-1 gpt-6.1-sol xhigh; glm-1 z-ai/glm-5.3); the seats initially differed on verification sufficiency, now resolved by independent registry checksum and completed FFI CI evidence. build aarch64-pc-windows-msvc is still in progress; keep merge gated until it completes successfully. This review does not authorize or perform a merge.

@Nic-dorman
Nic-dorman merged commit 5c3004d into main Oct 23, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants