Skip to content

UN-4506 [DEV] Show text and images in the v1 DocumentViewer, with a switcher slot - #2409

Open
muhammad-ali-e wants to merge 24 commits into
UN-4505-v1-pdf-toolbarfrom
UN-4506-v1-text-image-views
Open

muhammad-ali-e wants to merge 24 commits into
UN-4505-v1-pdf-toolbarfrom
UN-4506-v1-text-image-views

Merge branch 'UN-4505-v1-pdf-toolbar' into UN-4506-v1-text-image-views

55d3cc2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 3, 2026 in 1m 21s

Annotations

Check warning on line 54 in frontend/src/v1/components/patterns/document-viewer/ImageView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLSKbb5pd7eE3Gbn&open=AaGGtLSKbb5pd7eE3Gbn&pullRequest=2409

Check warning on line 106 in frontend/src/v1/components/patterns/document-viewer/TextView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLSIbb5pd7eE3Gbi&open=AaGGtLSIbb5pd7eE3Gbi&pullRequest=2409

Check warning on line 158 in frontend/src/v1/components/patterns/document-viewer/TextView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`tabIndex` should only be declared on interactive elements.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLSIbb5pd7eE3Gbk&open=AaGGtLSIbb5pd7eE3Gbk&pullRequest=2409

Check warning on line 124 in frontend/src/v1/components/patterns/document-viewer/ViewerToolbar.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLLbbb5pd7eE3Gbd&open=AaGGtLLbbb5pd7eE3Gbd&pullRequest=2409

Check warning on line 182 in frontend/src/v1/components/patterns/document-viewer/DocumentViewer.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLQmbb5pd7eE3Gbh&open=AaGGtLQmbb5pd7eE3Gbh&pullRequest=2409

Check warning on line 56 in frontend/src/v1/components/patterns/document-viewer/TextView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGa94cgjxf_orAgxyqX&open=AaGa94cgjxf_orAgxyqX&pullRequest=2409

Check warning on line 175 in frontend/src/v1/components/patterns/document-viewer/TextView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a stable ID as key, because the index changes when the list changes.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLSIbb5pd7eE3Gbm&open=AaGGtLSIbb5pd7eE3Gbm&pullRequest=2409

Check warning on line 397 in frontend/src/v1/components/patterns/document-viewer/DocumentViewer.test.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A presence assertion should use a `getBy*` query so a missing element produces Testing Library diagnostics.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGa94Xjjxf_orAgxyqW&open=AaGa94Xjjxf_orAgxyqW&pullRequest=2409

Check warning on line 200 in frontend/src/v1/components/patterns/document-viewer/ImageView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Non-interactive elements should not be assigned mouse or keyboard event listeners.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLSKbb5pd7eE3Gbo&open=AaGGtLSKbb5pd7eE3Gbo&pullRequest=2409

Check failure on line 125 in frontend/src/v1/components/patterns/document-viewer/DocumentViewer.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLQmbb5pd7eE3Gbe&open=AaGGtLQmbb5pd7eE3Gbe&pullRequest=2409

Check warning on line 154 in frontend/src/v1/components/patterns/document-viewer/DocumentViewer.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLQmbb5pd7eE3Gbg&open=AaGGtLQmbb5pd7eE3Gbg&pullRequest=2409

Check warning on line 162 in frontend/src/v1/components/patterns/document-viewer/TextView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Non-interactive elements should not be assigned mouse or keyboard event listeners.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLSIbb5pd7eE3Gbj&open=AaGGtLSIbb5pd7eE3Gbj&pullRequest=2409

Check warning on line 165 in frontend/src/v1/components/patterns/document-viewer/DocumentViewer.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGbBUFcALOZc6cdq18w&open=AaGbBUFcALOZc6cdq18w&pullRequest=2409

Check warning on line 403 in frontend/src/v1/components/patterns/document-viewer/DocumentViewer.test.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A presence assertion should use a `getBy*` query so a missing element produces Testing Library diagnostics.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGa94Xjjxf_orAgxyqV&open=AaGa94Xjjxf_orAgxyqV&pullRequest=2409

Check warning on line 136 in frontend/src/v1/components/patterns/document-viewer/DocumentViewer.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Mark the props of the component as read-only.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLQmbb5pd7eE3Gbf&open=AaGGtLQmbb5pd7eE3Gbf&pullRequest=2409

Check warning on line 193 in frontend/src/v1/components/patterns/document-viewer/ImageView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`tabIndex` should only be declared on interactive elements.

See more on https://sonarcloud.io/project/issues?id=Zipstack_unstract&issues=AaGGtLSKbb5pd7eE3Gbp&open=AaGGtLSKbb5pd7eE3Gbp&pullRequest=2409