Repository navigation
Conversation
Framework failure paths could persist a FAILED task without status.timestamp: the consumer failure path built a TaskStatusUpdateEvent with an unstamped TaskStatus (which TaskManager.save_task_event then CopyFrom'd over the task, clearing any prior timestamp), and the producer failure path mutated task.status.state directly before saving. DatabaseTaskStore derives last_updated from status.timestamp, so the task was persisted with last_updated = NULL, breaking ListTasks ordering and time-based filters (issue a2aproject#1331). Per the approach endorsed on the issue, this lands both layers: - failure sites in ActiveTask (_write_failed_status, _mark_task_as_failed, and the producer failure path) stamp the current time explicitly; - TaskManager.save_task_event gains a defensive backstop that auto-populates the timestamp whenever a terminal state arrives unstamped, covering raw Task and status-event paths alike. Non-terminal states are left untouched, and explicitly provided timestamps are never overwritten. Signed-off-by: andy <linux2011@qq.com>
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 95.40% | 95.45% | 🟢 +0.05% |
| src/a2a/server/cluster/database_event_stream.py | 92.86% | 96.94% | 🟢 +4.08% |
| src/a2a/server/tasks/task_manager.py | 98.86% | 98.92% | 🟢 +0.06% |
| Total | 93.13% | 93.18% | 🟢 +0.05% |
Generated by coverage-comment.yml
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Framework failure paths could persist a FAILED task without
status.timestamp, andDatabaseTaskStorederiveslast_updatedfromstatus.timestamp(database_task_store.py:152-156) — so the task was persisted withlast_updated = NULL, breakingListTasksordering andstatus_timestamp_afterfiltering. Root-cause analysis and a runtime reproduction are in #1331.Per the two-layer approach endorsed on the issue:
ActiveTask):_write_failed_status,_mark_task_as_failed, and the producer failure path now stamp the current time on the FAILED status.TaskManager.save_task_event: a terminal state arriving without a timestamp (rawTaskpath or status-event path) is auto-stamped with the current time, so future call sites cannot reintroduce the NULL-last_updatedhole.Semantics: non-terminal states are never touched, and explicitly provided timestamps are never overwritten.
fix:→ SemVer patch)Fixes #1331 🦕
Validation
TASK_STATE_FAILEDwithstatus.timestampset; non-terminal statuses and explicitly provided timestamps are untouched.state=TASK_STATE_FAILED, timestamp set=False(repro in [Bug]: Framework-written FAILED status drops status.timestamp, persisting last_updated as NULL #1331). AFTER:timestamp set=True.tests/server/tasks/test_task_manager.py(terminal-unstamped auto-stamp, provided-timestamp preserved, non-terminal untouched, raw-Task path guarded) + 1 end-to-end intest_default_request_handler_v2.py.2302 passed, coverage93%(gate 88%).Prepared with AI assistance (WorkBuddy); reviewed and verified by Linux2010