Repository navigation
feat: Add bento section for vitnode home page - #883
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
- Deleted the `navigation-tree.ts` file and its associated logic. - Removed `ADMIN_NAVIGATION_PERMISSIONS` from `admin-permissions.ts`. - Eliminated `ADMIN_NAVIGATION_SCREEN` from `admin-scope.ts`. - Removed tests related to header navigation in `header-content.test.tsx`. - Refactored `header-content.tsx` to simplify navigation rendering. - Updated `header-nav-menu.tsx` to remove skeleton loading and use icons directly. - Adjusted mobile navigation components to use icon components instead of strings. - Cleaned up navigation configurations in example and forum plugins.
… and reporting system
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b26b96870d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ); | ||
| } | ||
|
|
||
| return file.startsWith("/") && !file.includes("/node_modules/"); |
There was a problem hiding this comment.
On Windows, normalizeFile() converts file:///C:/... stack entries to drive-letter paths such as C:\app\src\route.ts, but this predicate only accepts paths beginning with /. Server-side application frames are therefore classified as framework frames, so the new error page cannot select or read the first application source frame and hides the useful stack by default. Use platform-aware absolute-path and node_modules checks instead.
Useful? React with 👍 / 👎.
| const tick = (now: number) => { | ||
| if (!origin) origin = now - elapsed | ||
| setT((now - origin) % cycle) | ||
| frame = requestAnimationFrame(tick) |
There was a problem hiding this comment.
Whenever this homepage tile is visible and reduced motion is disabled, the animation loop calls setT on every display frame indefinitely. That forces React to reconcile the entire collaborative-editor illustration at roughly the refresh rate for a decorative animation, increasing CPU use and battery drain on the public mobile homepage. Update only when a character or animation phase changes, or move the continuous portion to CSS.
Useful? React with 👍 / 👎.
| const report = reportedErrorOf(window.__vitnodeDevError); | ||
|
|
||
| return report.message === reportedErrorOf(error).message ? report : null; |
There was a problem hiding this comment.
After an SSR route error, window.__vitnodeDevError is never cleared when the user navigates away through the SPA. If a later browser-side error has the same message—a common case for generic errors such as fetch failed—this message-only comparison reuses the old server stack, path, hints, and runtime label, so the overlay diagnoses the wrong failure. Clear the report after hydration consumes it or match it with a per-error identifier.
Useful? React with 👍 / 👎.
…proved page tree handling
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be1711a278
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| return { | ||
| hints, | ||
| message: typeof message === "string" ? message : JSON.stringify(error), |
There was a problem hiding this comment.
When application code throws a circular object or an object containing a BigInt, this fallback throws from JSON.stringify while the development error page is itself rendering. Because TanStack error boundaries accept any thrown value, this replaces the original failure with a serialization error and prevents the overlay from diagnosing it; use a non-throwing serializer with a guaranteed string fallback.
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?