Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String metadata overrides such as
tokenizer.chat_template=str:user:ortokenizer.chat_template=str:{{ messages[0]['role'] == 'user' }}currently fail during server model setup withValueError: too many values to unpack. The parser splits the entire value at each=and:, including delimiters inside the string.Split only once at the key/value and type/value boundaries so the string reaches the model constructor unchanged. Add regression tests for colons, equals signs, empty values, Unicode, and existing numeric/boolean overrides, plus a changelog entry.
Validation on macOS arm64, Python 3.12.11, with the repository's pinned native library built with GPU backends disabled:
make testwithPYTEST_ADDOPTS="tests/test_server_model.py tests/test_llama_chat_format.py tests/test_llama_grammar.py tests/test_llama_speculative.py": 14 passed.make lint: Ruff checks and formatting pass acrossllama_cppandtests.The new tests use real server settings and loader code, mocking only model construction. No model weights were downloaded; the full model/inference suite was not run. The native dependency was built unchanged.
AI assistance was used for investigation, implementation, and validation.