Repository navigation
Conversation
Member
|
Where did we agree to do this? |
Contributor
Author
Seems, change was originally introduced in |
sacOO7
force-pushed
the
rename-rest-to-http-public-api
branch
from
October 29, 2026 17:14
dfc09d6 to
b4d6eed
Compare
- api-docstrings: the Connection recoveryKey and createRecoveryKey rows cited RTN16b and RTN16c, which have been replaced. They now cite RTN16g, and RTN16g and RTN16g3. Only the citations change. - REC1b2: add a non-normative note that endpoint identifies a host or routing policy and does not itself carry a port. A non-default port is set with port (TO3k4) or tlsPort (TO3k5). For example, localhost:8080 is not a hostname under REC1b2, so REC1b4 treats it as a routing policy ID. The specification version stays 6.3.0. Neither change adds API or required SDK behaviour, so the README's rules call for no minor bump.
sacOO7
force-pushed
the
rename-rest-to-http-public-api
branch
from
October 29, 2026 18:06
b4d6eed to
39db2c6
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small corrections found while aligning the 2.0 PubSub SDKs with the spec. Neither adds API or changes required SDK behaviour:
recoveryKeyandcreateRecoveryKeydocstrings now cite current spec points instead of replaced ones.REC1b2note. A non-normative note says thatendpointdoes not itself carry a port.This PR is a single commit on
main. An earlier version also renamedidempotentRestPublishingtoidempotentHttpPublishing(TO3s), updated the UTS to match, and markedRSA10l"(deprecated)". Those changes were dropped and the branch was squashed.idempotentRestPublishing(TO3n),RSC22d,RSL1k1,RSAN1c4,RTL6a1,RSA10l, the IDL anduts/are therefore unchanged frommain.1. api-docstrings:
recoveryKeyandcreateRecoveryKeycitationsBoth
Connectionrows citedRTN16bandRTN16c, which have been replaced:RTN16bwas replaced byRTN16gandRTN16m.RTN16cwas replaced byRTN16g2, which was in turn replaced byRTN16g3.The
recoveryKeyrow now citesRTN16g, which replaced it. ThecreateRecoveryKeyrow citesRTN16gandRTN16g3. Only the citations change.2.
REC1b2:endpointdoes not carry a portREC1b2gets an in-place note, in the "(Non-normative: ...)" form already used in the spec. It says three things:endpointidentifies a host or routing policy only and does not itself carry a port.port(TO3k4) ortlsPort(TO3k5).localhost:8080is not a hostname underREC1b2: it has no., contains no::, and is notlocalhost. SoREC1b4treats it as a routing policy ID.This only describes what the existing rules already do. It adds no requirement.
Specification version
The version stays at 6.3.0, and
build/data/versions.yamlis unchanged frommain. The README's Specification Version rules call for a minor bump when the SDK API changes compatibly or when SDKs must add new behaviour. Neither change does either:REC1b2note is non-normative.Fixes of this kind on
mainhave not bumped the version, for example f2e0dcd, b05edc7 and fd4ca01.Out of scope / follow-up
RestClient,RestChannel,RestPresenceandRestAnnotationskeep their names. Any rename would affect every SDK and needs agreement across them first.createWrapperSDKProxy(WP*, IDLRestClientInterface) maps onto the 2.0 SDKs' HTTP clients. That is a question of SDK conformance, not a spec change, so this PR leaves it out.RSA10lauthorisealias. This needs a cross-SDK decision: should the requirement be deleted now that 2.0 SDKs drop the alias? It is not marked "(deprecated)" here, because the spec reserves that marker for points that define a deprecated element or behaviour. Points that only require a deprecation warning, such asRTN4iandRTS4b, are unmarked.createRecoveryKeydocstring says it returns null whenSUSPENDED, butRTN16g3does not list that state.Validation
(cd build && npm install && npm run lint)passes. It reports no duplicate spec items in features.md, chat-features.md or objects-features.md.TO3k4,TO3k5,REC1b4,RTN16g,RTN16g3).REC1b2note does not change behaviour.REC1b2wording is now "does not itself carry a port", so it no longer reads as a prohibition.main.RSA10lmarker removal.RSA10lis byte-identical tomain.idempotentHttp,TO3s,TO3n1andTO3n2do not appear anywhere in the repo.uts/is identical tomain.mainis the two docstring rows and theREC1b2note.