Repository navigation
Conversation
Accept the documented secure_integration_key_key setting in the Sign connector schema, matching the existing credential loader. Cover secure and plaintext credentials and clarify the connector example. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve expanded connector tests on the adobe-sign-expanded-tests fork branch and retain only the two credential schema cases in the fix. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secure_integration_key_key, matching the existing credential loader and documented configuration. Previously the schema requiredsecure_integration_key, which the credential loader could not use.integration_keysupport and existing errors for conflicting credential settings or missing stored credentials.integration_keyand securesecure_integration_key_keyconfiguration.admin_emailusername.Testing Steps
secure_integration_key_key.python -m pytest -q --no-cov tests/test_sign_config.py tests/test_sign_engine.py tests/test_config.py: passed (41 passed, 1 skipped), including both cases of the new validation test.git diff --check: passed.9598ed9006c3513aa0d4e3012a5f3684d0c2176afor a possible later test-only follow-up. No follow-up PR has been submitted.AdobeSignCreds, with the same username asadmin_email. Inconnector-sign.yml, comment outintegration_keyand setsecure_integration_key_key: AdobeSignCreds. Run.\user-sync.exe sign-sync -twith a build containing this change and verify credential retrieval succeeds.Fixes #870