Repository navigation
Report RabbitMQ messages on the client queue as metric - #140
Merged
Merged
Conversation
Using a specific metric reporter in the taskmanager allows for easier filtering on client queue metrics in the dashboard.
Hilbrand
requested review from
BertScholten,
RonniLin,
SerhatG and
fmadjdian
September 28, 2026 12:39
Member
|
I had some small questions and was searching for the telemetry doc but that hasn't been updated. Can you add that part? Probably all my questions will be answered after reading that. :) |
Included sonar warning fix.
SerhatG
approved these changes
Oct 2, 2026
BertScholten
requested changes
Oct 2, 2026
|
Maybe I missed part of the discussion, but why gather information about RabbitMQ indirectly when RabbitMQ exposes this information also? Is it because it is not reachable? |
Also removed unused file BrokerConnectionEnum.
Member
Author
|
@RonniLin Yes RabbitMQ also provides this information. But with this we could opt not to gather the RabbitMQ metrics at all from RabbitMQ. But more importantly by providing the metrics via the TaskManager we add some additional information, which makes it simpler to process the metrics in the dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a specific metric reporter in the taskmanager allows for easier filtering on client queue metrics in the dashboard.