Skip to content

test: reap native app-server fixtures after each test - #615

Open
naiba wants to merge 1 commit into
agentclientprotocol:mainfrom
naiba:test/native-fixture-cleanup
Open

naiba wants to merge 1 commit into
agentclientprotocol:mainfrom
naiba:test/native-fixture-cleanup

Conversation

@naiba

@naiba naiba commented Oct 12, 2026

Copy link
Copy Markdown

Problem

Real test fixtures retain their app-server until worker exit. Protocol logging showed later command tests timing out during app-server initialization, before command handling.

Change

Dispose each real fixture after its owning test, close stdin first, await process exit, and use a bounded kill fallback. Keep the existing test-home cleanup on exit.

Validation

  • New regression was red before cleanup: the previous test app-server remained alive. All three fixture utility tests passed after the change.
  • Full local Bun suite without retries: 1493 passed, 36 pre-existing skipped. That run also included the separate idle-observer and workspace-symlink assertion changes; neither is included here.
  • Typecheck and build passed.

No command assertions were removed, no timeout was increased, and no retry was added.

Co-authored-by: naiba/CloudCode <hi+cloudcode@nai.ba>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant