Repository navigation
Conversation
…page
The test aborts the first device page server, starts the continued page
on the same port and requested it with the same client, which may still
pool a keep-alive connection to the aborted server; a request sent on it
is reset ("Connection reset by peer" in CI). Use a fresh client for the
continued page.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device_page_shows_code_and_tracks_completion_without_exposing_tokensaborts the first device page server, starts the continued page on the same port, and then requests it with the samereqwest::Client. That client may still pool a keep-alive connection to the aborted server, and a request sent on it is reset. The test failed in CI this way twice in a row on #171 (Connection reset by peeratgithub_oauth.rs:445), although that PR doesn't touch this code.The continued page now gets a fresh client. Test-only change.
I couldn't reproduce the failure locally: 0 failures in 240 runs on
main, including the test alone pinned to one CPU. The cause above is the most likely one, not confirmed.