Repository navigation
fix(ci): skip the version bump when task generate is a no-op - #586
Merged
Merged
Conversation
`.github/workflows/update.yml` was writing `version.go` unconditionally after `task generate`, so runs where the openapi schema hadn't moved still produced a PR whose only change was the version string. See #585. Guard the step on `git status --porcelain` (excluding `version.go` and the ignored `openapi.json`). On a clean working tree, the step logs "no changes" and exits, so `peter-evans/create-pull-request` sees nothing to commit and opens no PR.
vmyroslav
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/update.ymlwas writingversion.gounconditionally aftertask generate, so runs where the openapi schema hadn't moved still produced a PR whose only change was the version string. See #585.Guard the step on
git status --porcelain(excludingversion.goand the ignoredopenapi.json). On a clean working tree, the step logs "no changes" and exits, sopeter-evans/create-pull-requestsees nothing to commit and opens no PR.