Skip to content

ci(release)!: stop tracking the openapi.json hash in version.go - #588

Merged
byashimov merged 1 commit into
mainfrom
byashimov/NEX-2944/openapi-zip-asset
Oct 15, 2026
Merged

byashimov merged 1 commit into
mainfrom
byashimov/NEX-2944/openapi-zip-asset

Conversation

@byashimov

Copy link
Copy Markdown
Contributor

update.yml no longer writes OpenAPISpecHash() or the version into version.go; it regenerates from the fresh openapi.json and opens the PR, as before. openapi.json stays out of the repo and the releases.

With nothing written to version.go, release.yml tags each push to main that touches **.go, **/go.mod or **/go.sum with the next minor version, so the merge queue never has to accept a bot push. workflow_dispatch releases main on demand; an already-tagged commit is skipped. Version() reads the module version via runtime/debug.ReadBuildInfo(); local builds report v0.0.0.

BREAKING CHANGE: OpenAPISpecHash() is removed.

@byashimov
byashimov requested a review from a team as a code owner October 15, 2026 14:09
@byashimov
byashimov force-pushed the byashimov/NEX-2944/openapi-zip-asset branch from 9893b42 to 7cc96ec Compare October 15, 2026 14:14
Comment thread .github/workflows/release.yml Resolved
@byashimov
byashimov force-pushed the byashimov/NEX-2944/openapi-zip-asset branch from 7cc96ec to f8a7d84 Compare October 15, 2026 14:26
@byashimov
byashimov added this pull request to the merge queue Oct 15, 2026
@byashimov
byashimov removed this pull request from the merge queue due to a manual request Oct 15, 2026
`update.yml` no longer writes `OpenAPISpecHash()` or the version into
`version.go`; it regenerates from the fresh `openapi.json` and opens the
PR, as before. `openapi.json` stays out of the repo.

With nothing written to `version.go`, `release.yml` tags each push to
`main` that touches `**.go`, `**/go.mod` or `**/go.sum` (excluding
`**_test.go` and `generator/**`) with the next minor version, so the
merge queue never has to accept a bot push. Each release attaches the
current `openapi.json` as `openapi.zip`. `workflow_dispatch` releases
`main` on demand; an already-tagged commit is skipped. `Version()` reads
the module version via `runtime/debug.ReadBuildInfo()`; local builds
report `v0.0.0`.

BREAKING CHANGE: `OpenAPISpecHash()` is removed.
@byashimov
byashimov force-pushed the byashimov/NEX-2944/openapi-zip-asset branch from f8a7d84 to aad2c69 Compare October 15, 2026 14:38
@byashimov
byashimov added this pull request to the merge queue Oct 15, 2026
Merged via the queue into main with commit 4417f08 Oct 15, 2026
6 checks passed
@byashimov
byashimov deleted the byashimov/NEX-2944/openapi-zip-asset branch October 15, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants