Repository navigation
work-h70kv.156: filed findings - #325
Merged
Merged
Conversation
ConsoleRenderer writes the event, logger and logger_name columns with str rather than repr, so a non-string there reached stderr with its terminal control bytes. Those columns are now converted to str and stripped like any other string. Unit: work-1cvbf
A str subclass logged as the event or the logger name went through its own __str__ before the strip: one whose __str__ raises made the log call raise, and a (str, Enum) member printed its member name instead of its value. A str is now stripped as the text it holds, as before. Unit: work-1cvbf Fixes-unit: work-1cvbf
Two keys that strip to the same name keep the later value. Keys are now stripped before any value is converted, so the value a later key replaces is never passed to str() and cannot make the log call raise. Unit: work-1cvbf Fixes-unit: work-1cvbf
Unit: work-1cvbf
ak2k
marked this pull request as ready for review
October 27, 2026 00:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A -vv debug line no longer carries terminal control bytes when a non-string is logged as the event or the logger name.
Class: STANDARD
Gates:
03-oracle: green
04-review: FINDINGS
06-oracle: green
07-gate: AGREEMENT_FINDINGS
10-oracle: green
11-gate: AGREEMENT_CLEAN
Commits: