Repository navigation
feat(workflow): boundary events on call workflow (mendixlabs/mxcli#1532) - #1530
Merged
Merged
Conversation
`create workflow … call workflow M.Child … boundary event interrupting timer …`
failed to parse ("mismatched input 'boundary' expecting ';'"), although the
reader, writer, describer, ALTER mutator and MCP backend all handle
Workflows$CallWorkflowActivity.boundaryEvents (10.14+, the same floor as every
other owner). DESCRIBE printed the clause for such an activity, so its output
did not re-parse.
workflowCallWorkflowStmt now takes call microflow's exact boundary-event clause
(no new tokens), the visitor fills a new BoundaryEvents field on
WorkflowCallWorkflowNode, and buildCallWorkflowActivity writes them through
buildBoundaryEvents.
The AST walkers each switched on the boundary-event owners themselves and none
knew call workflow, so WF07/08/09/10/15/18/19, the rewrite guard's count and the
11.11 notification gate would have skipped the new bodies. A single helper,
workflowActivityBoundaryEvents, now lists the owners; the two walkers that label
by owner (WF15, WF19) gained the case. On the stored side, ALTER's end-ancestry
walk lost the non-interrupting context under a call workflow and MDL-WF05 did
not see jump targets inside its boundary body; both gained the case.
Measured: interrupting and non-interrupting timer boundary events on call
workflow, mx check 0 errors on 11.6.6 and 11.15.0; describe -> exec "already in
sync" on both. A notification boundary event on call workflow is 0 errors on
11.15.0 and refused by the existing 11.11 gate on 11.6.6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W3x8Fyvir8kLyPgJs1BDmF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements mendixlabs#1532 (#1414), approved by the maintainer.
The gap
create workflow … call workflow M.Child … boundary event interrupting timer …failed withmismatched input 'boundary' expecting ';'. The reader, writer, describe, ALTER and the MCP backend already handled boundary events on a CallWorkflowActivity, sodescribeprinted a clause that would not parse back.Fix
Grammar:
workflowCallWorkflowStmtreusescall microflow's exact boundary-event clause. No new tokens.AST, visitor and builder:
WorkflowCallWorkflowNode.BoundaryEventsis filled by the visitor and written bybuildCallWorkflowActivity.Validation walkers. Eight hand-written walkers over boundary events skipped
call workflow:They now share one helper,
workflowActivityBoundaryEvents, so rules and reference checks also check a call workflow's boundary bodies.Walkers over stored workflows: two had the same gap and are fixed too.
Version gating: the metamodel puts boundary events on CallWorkflowActivity at the same floor (10.14.0) as other activities. A notification boundary event hits the existing 11.11 gate.
Tests
visitor_workflow_callworkflow_boundary_test.go: the issue's repro, and the oldwith (…)form with a clause after it.workflow_callworkflow_boundary_test.go:Measured with mx check (fixture copies)
{ end workflow; }{ wait for timer … }Also in this PR: syntax help (
workflow.call-workflow,workflow.boundary-event), the write-workflows skill,docs-site/src/language/workflow-activities.md, a finding file, andmdl-examples/bug-tests/1532-call-workflow-boundary-events.mdl.make build,make test,make lint,make check-findingsandmake check-skill-indexpass.Not done
end workflowinside a non-interrupting boundary under a call workflow gives CE1844. exec refuses it, by analogy with user tasks.call microflow;workflow.boundary-eventsyntax entry says MinVersion 10.6.0, where the metamodel says 10.14.0.Generated by Claude Code