Skip to content

157 fix auto refresh status not updating on plugin errors #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akyriako merged 2 commits into from
Oct 16, 2026
Merged

157 fix auto refresh status not updating on plugin errors #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
885621c
moved genid and pause toggle in seterror #157
akyriako Oct 16, 2026
6e3dc2e
reenable autorefresh if tableviewport or previous view had rows #157
akyriako Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions internal/ui/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,15 +184,18 @@ func (m *Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
switch msg.String() {
case "esc", "enter":
m.setError(nil)
m.autoRefreshPaused = false

cmd := m.scheduleAutoRefresh()

if len(m.navigation) > 0 {
return m, tea.Batch(m.navigateBack(), cmd)
m.autoRefreshPaused = false
return m, tea.Batch(m.navigateBack(), m.scheduleAutoRefresh())
}

if m.loaded {
m.autoRefreshPaused = false
return m, m.scheduleAutoRefresh()
}

return m, cmd
return m, nil

case "ctrl+x":
return m, tea.Quit
Expand All @@ -218,10 +221,6 @@ func (m *Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
return m, nil
}

m.autoRefreshPaused = true
m.autoRefreshGeneration++
m.autoRefreshScheduled = false

m.loading = false
m.showLoading = false
m.loadingLabel = ""
Expand All @@ -232,10 +231,6 @@ func (m *Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
return m, nil

case resource.ErrorMsg:
m.autoRefreshPaused = true
m.autoRefreshGeneration++
m.autoRefreshScheduled = false

m.loading = false
m.showLoading = false
m.loadingLabel = ""
Expand Down
4 changes: 4 additions & 0 deletions internal/ui/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ func (m *Model) setError(err error) {
return
}

m.autoRefreshPaused = true
m.autoRefreshGeneration++
m.autoRefreshScheduled = false

m.resizeErrorViewport()
}

Expand Down
Loading