Skip to content

Guard benchmark option and add regression coverage - #477

Merged
qicosmos merged 3 commits into
alibaba:mainfrom
ajavanma:cmake-benchmark-option
Sep 13, 2026
Merged

Guard benchmark option and add regression coverage#477
qicosmos merged 3 commits into
alibaba:mainfrom
ajavanma:cmake-benchmark-option

Conversation

@ajavanma

@ajavanma ajavanma commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This PR makes benchmark discovery optional in CMake and adds regression coverage.

  • Add ASYNC_SIMPLE_ENABLE_BENCHMARKS option default ON in root CMakeLists.
  • Only find and add benchmarks/ subdir when option is enabled.
  • Document behavior and usage in README.
  • Add regression test ensuring --clean-ctest with BENCHMARK option disabled does not touch benchmark discovery.

@CLAassistant

CLAassistant commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

qicosmos
qicosmos reviewed Sep 12, 2026
View reviewed changes
Comment thread CMakeLists.txt Outdated
find_package(Benchmark)

option(ASYNC_SIMPLE_ENABLE_TESTS "Build the tests" ON)
option(ASYNC_SIMPLE_ENABLE_BENCHMARKS "Build benchmarks when Benchmark is available" ON)

@qicosmos qicosmos Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default OFF is better.

@qicosmos
qicosmos merged commit 0c7a12b into alibaba:main Sep 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qicosmos qicosmos qicosmos left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajavanma @CLAassistant @qicosmos