Repository navigation
Keep parenthesized expressions in identifier lists - #932
Open
adenzhou1350 wants to merge 1 commit into
Open
adenzhou1350 wants to merge 1 commit into
adenzhou1350 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #343.
Bare parenthesized expressions currently break a comma-separated identifier list. For example,
SELECT a, b, (a-b) FROM blagroups onlya, b, so reindent leaves the last expression on the wrong line.Accept parenthesized list items and group VALUES before identifier lists, keeping each top-level VALUES row separate. Expressions inside those rows still form their own lists.
Tests cover first/middle/last items, adjacent and nested parentheses, scalar subqueries, reindent output, and VALUES row boundaries. The 12 new cases have 11 failures on the original grouping implementation; all pass after the fix.
Validation on native Windows Python 3.12 and 3.14: full suite 518 passed, 2 xfailed, 1 existing xpassed; Ruff and diff checks pass. Third-party pytest plugin autoload was disabled. The existing wide-column benchmark reports linear scaling from 500 to 4,000 columns. Linux/macOS and the remaining Python versions are left to CI.
AI-assisted implementation and local validation.