Repository navigation
fixes NPE in bulkv1 code after failure - #6622
Merged
Merged
Conversation
Changes in apache#6620 introduced a potential NPE when status is removed from map.
keith-turner
commented
Oct 29, 2026
| long fileSize, FileStatus status, Collection<KeyExtent> extents, FileSystem ns, | ||
| Cache<String,Long> fileLenCache, CryptoService cs) throws IOException { | ||
|
|
||
| final long fileSize = status.getLen(); |
Contributor
Author
There was a problem hiding this comment.
This was the potential NPE when a status was removed from a map on failure.
dlmarion
reviewed
Oct 30, 2026
Contributor
Author
|
Since these problems only happen with failures, manually modified the code to randomly fail in order to test this change and #6620. Ran BulkIT.testOld() multiple times w/ the random failures happening. Attached the diff used for testing. |
dlmarion
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in #6620 introduced a potential NPE when status is removed from map.