Repository navigation
GH-55312: [C++][Compute] More flexible kernel exec generation - #55291
Merged
Merged
Conversation
pitrou
marked this pull request as draft
October 27, 2026 19:25
Member
Author
|
@zanmato1984 This is what I had in mind in #55169 (comment) |
pitrou
changed the title
pitrou
force-pushed
the
kernel-generator
branch
6 times, most recently
from
October 29, 2026 14:13
6b9e004 to
4eda8a8
Compare
pitrou
marked this pull request as ready for review
October 29, 2026 14:13
pitrou
changed the title
pitrou
force-pushed
the
kernel-generator
branch
from
October 29, 2026 14:52
4eda8a8 to
b025a34
Compare
Member
Author
|
This is ready for review @zanmato1984 @HuaHuaY . |
3 of 5 tasks
zanmato1984
approved these changes
Oct 30, 2026
zanmato1984
left a comment
zanmato1984
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the cleanup! The new generator interface looks good to me. I left two minor documentation comments inline.
github-actions
Bot
added
awaiting committer review
pitrou
force-pushed
the
kernel-generator
branch
from
November 2, 2026 10:16
b025a34 to
a005993
Compare
Member
Author
|
I've addressed the review comments now. I'll watch for CI and merge if green. Thank you @zanmato1984 ! |
HuaHuaY
approved these changes
Nov 2, 2026
HuaHuaY
reviewed
Nov 2, 2026
Member
Author
|
CI failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Our kernel generation utilities in
arrow/compute/kernels/codegen_internal.hare a hodge-podge of hand-written switch statements with inconsistent template parameter signatures and semantics.This PR makes those more flexible, more consistent and more reusable.
What changes are included in this PR?
kAllTypeIds,kIntegerTypeIds...)TypeIdTraitsspecializationstype_idstatic member definitions onRunEndEncodedTypeandExtensionTypeAre these changes tested?
Yes, by existing tests and new unit tests around type id traits.
Are there any user-facing changes?
No.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: