Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonbaseddefaultdispatcher.findService picks the service from the namespace of the soap body's first element. that is the content-based dispatch SOAPMessageBodyBasedDispatcher and SOAPMessageBodyBasedServiceDispatcher now refuse unless allowContentBasedServiceDispatch is set (ContentBasedDispatchPolicy), because Dispatch runs after the Security phase. the json copy of that code kept the old behaviour, and it is the only Dispatch-phase dispatcher in the spring-boot-starter axis2-json.xml, whose application/xml builder puts the caller's root element in the body: a POST whose uri names no service, carrying <x:a xmlns:x="http://h/axis2/services/Target"/>, binds Target after Security has already run against no service. apply the same policy check at the top of findService. json-rpc requests carry an empty body, so their dispatch is unchanged. JSONBasedDefaultDispatcherTest fails before the change; the kernel, json and spring-boot-starter tests pass after.