Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sessionmanager.getSessionContext now creates transport session keys with UIDGenerator.generateURNString, the SecureRandom-backed UUID the soap session path in ConfigurationContext already uses for its service group context id, instead of generateUID. generateUID is a per-thread constant (start time and thread id) followed by a per-thread counter XORed with one per-JVM value, and on the standalone server (SimpleHTTPServer / AxisHttpService) that key is all a caller presents, in an axis_session or JSESSIONID request header read by RequestSessionCookie, to be bound to a SessionContext and its transportsession-scoped service instances. since ResponseSessionCookie hands every caller their own key, one anonymous request tells you the fixed 32 hex characters for that worker thread, and the next key issued on it differs only in the counter's low bits: one of 64 candidates when nothing else drew a UID on the thread in between, a small search otherwise (CWE-330, predictable session identifier). the servlet path uses the container's HttpSession and is unaffected. SessionManagerTest gets a regression that derives the 64 candidates from each key and fails before the change (the next key is among them) and passes after; the transport-http module's verify is green (112 tests).