Repository navigation
perf: Pass logging arguments as const-ref to prevent repetitive copying - #278
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slight improvement to logger. Pass arguments as const-ref to prevent copying.
EnforcercallsLogPrint()in various locations, e.g. in the loop iterating the policy. This creates a copy every time.casbin-cpp/casbin/enforcer.cpp
Lines 104 to 105 in 0ad64a7
LogPrint()itself passes arguments to an instance ofDefaultLogger, which takes another copy.casbin-cpp/include/casbin/log/default_logger.h
Line 22 in 0ad64a7
Internal logger is a no-op and copy elision may help, but i was still able to measure slight performance improvement.
Copies should be avoided unless required, e.g. for asynchronous processing.
This may affect existing implementations of the abstract
Logger-class.