Repository navigation
optimise prometheus scraping workflow - #13650
DaanHoogland wants to merge 12 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13650 +/- ##
============================================
+ Coverage 16.32% 16.47% +0.15%
- Complexity 13556 13743 +187
============================================
Files 5669 5669
Lines 501399 505527 +4128
Branches 60902 62616 +1714
============================================
+ Hits 81847 83309 +1462
- Misses 410390 412934 +2544
- Partials 9162 9284 +122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7835881 to
d765e5d
Compare
1951bdb to
2d2c40b
Compare
|
|
[SF] Trillian test result (tid-16835)
|
|
@NuxRo please test? @Damans227 and @shwstppr , can you review? |
|
what happens if the workers setting changes while two capacity runs overlap? looks like one can hand work to the pool that just got shut down |
Damans227
left a comment
There was a problem hiding this comment.
thanks @DaanHoogland, resizing the pool in place covers the overlap case. LGTM
|



Description
This PR...
Fixes: #13586
this should solve the issue, but claude suggested the following improvements as well:
if anyone wants to, these are nice to haves/good first issue ;)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?