Repository navigation
Conversation
…ect role permissions
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #14318 +/- ##
=========================================
Coverage 16.39% 16.39%
- Complexity 13631 13638 +7
=========================================
Files 5669 5669
Lines 501541 501541
Branches 60925 60925
=========================================
+ Hits 82228 82251 +23
+ Misses 410104 410077 -27
- Partials 9209 9213 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reordering a project role's rules looked up each rule id on its own and never checked that it belonged to the project or role the call was made for. This makes reorder and single rule updates use the same lookup, which rejects rule ids from another project, and reorder also rejects rules from another role in the same project.
Test:
Unit tests added for a rule from another project, a rule from another role, and a normal reorder.