Repository navigation
Conversation
Consume skipped characters through the substituted reader so counts and positions reflect the output stream. Reject skip after this wrapper closes and cover expansion, contraction, EOF, and wrapped readers that cannot skip. Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/TEXT-243
StringSubstitutorReader.skip(long) currently advances the wrapped template reader, so its count and position disagree with the substituted output. Consume output through this reader’s read path and reject skipping after the wrapper closes. Add regression coverage for expansion, contraction, partial reads, EOF, large counts, and wrapped readers whose skip fails.
Validation: focused reader tests passed (18 new, 83 existing). The default Maven build passed on JDK 17: 2,007 tests, 0 failures/errors, 3 skips. Java 8 runtime and hosted CI were not exercised locally.
AI assistance: OpenAI Codex helped investigate, prepare the patch and tests, and review.