Repository navigation
Conversation
An unescaped '{' lets bash and zsh brace-expand the escaped value, so
escapeXSI("{report.txt,-delete}") still expands to two words when the
result is passed to bash -c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringEscapeUtils.ESCAPE_XSIbackslash-escapes shell metacharacters but leaves{alone, so bash and zsh still apply brace expansion to the escaped value.escapeXSI("{report.txt,-delete}")comes back unchanged, andbash -c "find . -name " + escapedrunsfind . -name report.txt -delete: one escaped value becomes two arguments, and the second is an option chosen by whoever supplied the input.Repro, before the fix:
bash -c "printf '<%s>\n' " + escapeXSI("{report.txt,-delete}")prints<report.txt>and<-delete>. After the fix it prints one argument,<{report.txt,-delete}>. Escaping{alone stops the expansion, the same way the map escapes[but not].UNESCAPE_XSIalready round-trips\{.The new assertions in
StringEscapeUtilsTest#testEscapeXSIfail without the main change and pass with it. The defaultmvnbuild is green.mvn; that'smvnon the command line by itself.